Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): choose pull request event with path changes #1962

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Jan 14, 2025

To be able to run CI for external contribution, through forked repository, and be able to test CI modification in a development branch, we need to discriminate pull request events.
For the former 'pull_request_target' event is needed to have access to GitHub secrets. 'pull_request' event is required for the latter otherwise the workflow would be pulled from the HEAD of the base branch and thus wouldn't contain changes from the developer.

To be able to run CI for external contribution, through forked
repository, and be able to test CI modification in a development
branch, we need to discriminate pull request events. For the
former 'pull_request_target' event is needed to have access to
GitHub secrets. 'pull_request' event is required for the latter
otherwise the workflow would be pulled from the HEAD of the base
branch and thus wouldn't contain changes from the developer.
@soonum soonum added the ci label Jan 14, 2025
@soonum soonum requested a review from IceTDrinker January 14, 2025 12:09
@soonum soonum self-assigned this Jan 14, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 14, 2025
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try this

@soonum soonum merged commit 594157e into main Jan 14, 2025
217 checks passed
@soonum soonum deleted the dt/ci/path_for_event branch January 14, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants